Skip to content

fix static 404 & 500 in page router #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2024

Conversation

conico974
Copy link
Contributor

When using page router and static 404 and 500 ( i.e. no getStaticProps ) open-next build would fail because it cannot find the js file.

Copy link

changeset-bot bot commented May 24, 2024

🦋 Changeset detected

Latest commit: 4091182

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
open-next Patch
app-pages-router Patch
app-router Patch
tests-unit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 10:53am

@conico974 conico974 force-pushed the fix/static-404-page branch from 6cc2b53 to 4091182 Compare May 24, 2024 10:52
@conico974 conico974 merged commit 1b3c6fe into opennextjs:main May 24, 2024
3 checks passed
@conico974 conico974 deleted the fix/static-404-page branch October 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant